On Thu, 8 May 2014, Dan Williams wrote:
> > Also, instead of adding another #ifdef here, you could add a #else
> > section to the existing #ifdef in which you define an inline version of
> > hub_handle_remote_wakeup() (or a macro version) that always returns 0.
>
> I originally started down that path, and then noticed:
>
> #ifdef CONFIG_PM_RUNTIME
> } else if (udev->state == USB_STATE_SUSPENDED &&
> udev->persist_enabled) {
> /* For a suspended device, treat this as a
> * remote wakeup event.
> */
> usb_unlock_port(port_dev);
> status = usb_remote_wakeup(udev);
> usb_lock_port(port_dev);
> #endif
>
> ...right above and made the wrong call to add more ugliness. Will
> fix, but will leave the other ifdef excursions alone for now.
Yeah, I never tried very hard to encapsulate that bit away from the
rest of the subroutine.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
