Dear Felipe Balbi, On Wed, 7 May 2014 10:10:08 -0500, Felipe Balbi wrote: > > ifneq ($(CONFIG_USB_XHCI_MVEBU), ) > > xhci-hcd-y += xhci-mvebu.o > > endif > > > > Right? > > correct :-) > > > If so, then what about instead making CONFIG_USB_XHCI_MVEBU a bool > > instead of a tristate? It's more an option for the xhci-platform > > driver than an additional separate module, IMO. What do you think? > > fine by me too. It simply adds a quirk callback to xhci-plat. In the end, I settled on keeping the tristate, and used your suggestion. Because since xhci-plat itself is a blind option, and xhci-mvebu selects it, if xhci-mvebu is a bool, there would no longer be a way to have xhci-plat as a module. At least that's my understanding of the kconfig stuff :) Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html