RE: [RFC 0/9] cdc_ncm: add buffer tuning and stats using ethtool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bjørn Mork
> I have got quite a few reports from frustrated users of OpenWRT
> hosts trying to use some powerful LTE modem, but not achieving
> full speed.  This is typically caused by a combination of
> big buffers and little memory, giving in allocation errors and
> bad performance as a result.
> 
> This series is an attempt to let users adjust the size of these
> buffers without having to rebuild the driver.

I think that the usbnet rx framework needs some TLC.

There is no reason to pass large rx URB to the usb device.
Because the end of a USB bulk 'message' is indicated by a non-maximal
fragment (possibly zero length) it is sufficient to provide multiple
rx URB provided the URB are each a multiple of the packet size of the
underlying USB link (512 bytes for USB2 and 1k for USB3).

The usb driver might then have to split and merge data from
multiple URB to generate the data skbs.
I'd guess that for sub-Ge speeds a data copy in the rx path
won't matter - simplifying many of the drivers.

Some of the drivers allocate 16k skb, then set true_size small!

	David

��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux