Re: [PATCH V2 4/5] dwc3: host: Enable USB3 LPM capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 05, 2014 at 11:35:57PM +0800, Felipe Balbi wrote:
> On Mon, May 05, 2014 at 03:30:08PM +0530, Pratyush Anand wrote:
> > All dwc3 based xhci host controller supports USB3.0 LPM functionality.
> > Therefore enable it in platform data for all dwc3 based xhci device.
> > 
> > Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx>
> > ---
> >  drivers/usb/dwc3/host.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> > index 32db328..4f8c361 100644
> > --- a/drivers/usb/dwc3/host.c
> > +++ b/drivers/usb/dwc3/host.c
> > @@ -16,12 +16,14 @@
> >   */
> >  
> >  #include <linux/platform_device.h>
> > +#include <linux/usb/xhci_pdriver.h>
> >  
> >  #include "core.h"
> >  
> >  int dwc3_host_init(struct dwc3 *dwc)
> >  {
> >  	struct platform_device	*xhci;
> > +	struct usb_xhci_pdata 	pdata;
>                              ^trailing whitespace
> 
> can you make sure to initialize this to zero ? memset will do. The idea
> is that if other fields are added to the structure, it's impossible to
> cause regressions due to unitilized fields here.

ok.

Pratyush
> 
> -- 
> balbi


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux