Re: [PATCH v3 5/5] usb: qcserial: remove interface number matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 27, 2014 at 04:47:46PM +0200, Bjørn Mork wrote:
> From: Bjørn Mork <bjorn@xxxxxxx>
> 
> Matching on interface numbers was not such a good idea
> for multi-function serial devices after all. It is much
> better do create well defined device layouts, allowing
> a single match entry per device.
> 
> Remove this now unused code.
> 
> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>

Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>

> ---
>  drivers/usb/serial/qcserial.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index 91e7bb515398..ca7b43092439 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -190,13 +190,6 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id)
>  
>  	}
>  
> -	/* allow any number of interfaces when doing direct interface match */
> -	if (id->match_flags & USB_DEVICE_ID_MATCH_INT_NUMBER) {
> -		dev_dbg(dev, "Generic Qualcomm serial interface found\n");
> -		altsetting = 0;
> -		goto done;
> -	}
> -
>  	/* default to enabling interface */
>  	altsetting = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux