On Tue, Apr 29, 2014 at 8:12 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, 28 Apr 2014, Dan Williams wrote: >> ...and as I go to add this I notice that prior to the "use >> pm_request_resume" suggestion we don't de-reference port_dev->child in >> usb_port_runtime_resume(). This realization plus the usage count >> tracking that usb_remote_wakeup() affords is leaning me towards >> leaving the "force wakeup" mechanism as is for the upcoming re-post. > > The usage count tracking isn't an issue; that's the way autosuspend is > meant to work. Also, you're abusing usb_wakeup_notification() by > calling it for something that wasn't triggered by a remote wakeup > request from the device. I've been testing this and the pm_request_resume() ends up leaving the usb device enabled indefinitely. It needs to be paired with a pm_runtime_autosuspend(), but at that point why not just add a usb_autoresume_device_async() helper. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
