Re: [PATCH usb-linus v2 2/4] usb: qcserial: define and use Sierra Wireless layout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johan Hovold <jhovold@xxxxxxxxx> writes:
> On Fri, Apr 25, 2014 at 09:31:56PM +0200, Bjørn Mork wrote:
>> @@ -261,6 +255,29 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id)
>>  			break;
>>  		}
>>  		break;
>> +	case QCSERIAL_SWI:
>> +		/* Sierra Wireless layout:
>> +		   0: DM/DIAG (use libqcdm from ModemManager for communication)
>> +		   2: NMEA
>> +		   3: AT-capable modem port
>> +		   8: QMI/net
>> +		*/
>
> Just a minor style issue. The preferred multi-line comment style is:
>
> 	/*
> 	 * ...
> 	 */

Yes, I know - despite submitting an occasional netdev patch :-)

The idea was using the same style as other comments in this file. But
you're right:  That's not the way to do it.  I'll resubmit with this
fixed up an an additional patch fixing the other comments.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux