From: Johan Hovold > During firmware download the device expects memory addresses in > big-endian byte order. As the wIndex parameter which hold the address is > sent in little-endian byte order regardless of host byte order, we need > to use swab16 rather than cpu_to_be16. That doesn't sound correct. If the value needs to be little-endian, shouldn't you be using cpu_to_le16() ? If there is a second cpu_to_be16() being done later on then the code might be right, but the comments are misleading. David -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html