On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote: > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX"); > + if (IS_ERR(motg->vddcx)) { > + dev_err(motg->phy.dev, "unable to get hsusb vddcx\n"); > + return PTR_ERR(motg->vddcx); > + } > + > + motg->v3p3 = devm_regulator_get(motg->phy.dev, "HSUSB_3p3"); > + if (IS_ERR(motg->v3p3)) { > + dev_err(motg->phy.dev, "unable to get hsusb 3p3\n"); > + return PTR_ERR(motg->v3p3); > + } > + > + motg->v1p8 = devm_regulator_get(motg->phy.dev, "HSUSB_1p8"); > + if (IS_ERR(motg->v1p8)) { > + dev_err(motg->phy.dev, "unable to get hsusb 1p8\n"); > + return PTR_ERR(motg->v1p8); > + } It seems that calling devm_regulator_bulk_get() here would simplify the code here. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html