On Wed, Apr 23, 2014 at 9:15 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote: > For internal PHY (like UTMI), the phy clock may from internal pll, > it is on/off on the fly, the access PORTSC.PTS will hang without > phy clock. So, the usb_phy_init which will open phy clock needs to > be called before hw_phymode_configure. > See: http://marc.info/?l=linux-arm-kernel&m=139350618732108&w=2 > > For external PHY (like ulpi), it needs to configure portsc.pts before > visit viewport, or the viewport can't be visited. so phy_phymode_configure > needs to be called before usb_phy_init. > See: cd0b42c2a6d2a74244f0053f8960f5dad5842278 Chris sent cd0b42c2a6d2 when he was trying to get mx27 USB to work. He was also trying to add ULPI device tree support at that time (this was not accepted in mainline) and the issue that cd0b42c2a6d2 aims to solve was observed with the ULPI dt patches in place. Last week I fixed USB on mx27 and used the generic nop phy instead. It worked fine even if I revert cd0b42c2a6d2. So why don't we simply revert cd0b42c2a6d2 instead? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
