hi all: When I grep "HCD_FLAG_POLL_RH", I ave some questions: 1. why this flag only seems used by xhci, uhci, ohci except ehci? 2. it seems to setup when pcd happen and need to poll port status. And clear it when hcd_died, hcd_remove, hcd_suspend and no port change in hub_status_data 3. if we once set this flag up, we may need to test it when we needed. But why there is no test bit case in usb driver? appreciate your kind help in advance, PS:Below is my grep results: # grep -rwn 'HCD_FLAG_POLL_RH' drivers/usb/* drivers/usb/c67x00/c67x00-hcd.c:284: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2386: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2396: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2749: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2753: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2826: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/core/hcd.c:2833: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/xhci-hub.c:1088: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/uhci-hcd.c:144: clear_bit(HCD_FLAG_POLL_RH, &uhci_to_hcd(uhci)->flags); drivers/usb/host/uhci-hcd.c:375: set_bit(HCD_FLAG_POLL_RH, &uhci_to_hcd(uhci)->flags); drivers/usb/host/uhci-hcd.c:377: clear_bit(HCD_FLAG_POLL_RH, &uhci_to_hcd(uhci)->flags); drivers/usb/host/uhci-hcd.c:395: set_bit(HCD_FLAG_POLL_RH, &uhci_to_hcd(uhci)->flags); drivers/usb/host/uhci-pci.c:183: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/uhci-pci.c:243: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/hwa-hc.c:161: set_bit(HCD_FLAG_POLL_RH, &usb_hcd->flags); drivers/usb/host/xhci.c:868: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/xhci.c:1068: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/ohci-hub.c:497: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/ohci-hub.c:499: clear_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/xhci-ring.c:1873: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/ohci-hcd.c:693: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/ohci-hcd.c:857: set_bit(HCD_FLAG_POLL_RH, &hcd->flags); drivers/usb/host/whci/hcd.c:72: set_bit(HCD_FLAG_POLL_RH, &usb_hcd->flags); -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html