On 09/04/14 14:24, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki > <s.nawrocki@xxxxxxxxxxx> wrote: >> > On 09/04/14 13:54, Vivek Gautam wrote: >>> >> Adding support to enable/disable VBUS hooked to a gpio >>> >> to enable vbus supply on the port. >> > >> > Does the GPIO control a fixed voltage regulator ? If so, shouldn't >> > it be modelled by the regulator API instead ? > > No, this GPIO controls a 'current limiting power distribution switch', > which gives the output vbus to usb controller. > Should i model this as a fixed regulator ? OK, it's just a power switch then. I suspect using the regulator API would be more universal, as such a GPIO is somewhat a board design detail. I'm not going to object to your patch, just might be better to use the gpiod API instead. -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
