On Wed, Feb 19, 2014 at 09:25:14PM +0100, Krzysztof Opasiak wrote: > Hi Matt, > > as we have spoken some time ago, I have prepared patches which > hides definitions of internal library structures. > > User shouldn't have access to internal libraries structures which he could > modify. To avoid this I have provided some public structures which contains > attributes of gadget/config/function and strings. This allowed to remove > definitions of gadget/function/config from header file and provide only nice > typedefs for them. I have also done some API upgrade to allow setting of all > attributes with only one function call. I have also changed the sizes and order > of attributes in public structures to be consistent with USB standard and > libusb implementation. This allow for example to memcpy() from > libusb_device_descriptor to usbg_gadget_attributes. > > Moreover, there were some bugs and missing functionality. I have fixed some > wrong paths and add missing API functions. > > I hope that you will enjoy this code and merge it when it will be possible. > > I would like also to remind you that you didn't merge the previous series > of patches [1]. This series depends on previous one so please update github > repository. > > Footnotes: > > 1 - http://permalink.gmane.org/gmane.linux.usb.general/102224 This all looks good, applied from your pull request. Thanks. -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
