> > > I don't know why diff deletes: > > > -#define HP_VENDOR_ID 0x03f0 > > > -#define HP_LD220_PRODUCT_ID 0x3524 > > > > > > and then adds them again. I didn't touch those lines. I suspect that > > > it is due to the comment update above them. > > > > Well, you or your editor did add that extra space at the beginning of those > > lines (which git-diff reports). > > > > Your original diff was correct (although not generated from the root). > > Simply commit it to a git tree and run git format-patch and all should be good. > > In the original submission I did not change the comment about the pole > display. I noticed in a revision that comment referred to only one of > the poles. I tried committing the change and comparing back to the > tag, but I get it still removes the lines and adds them again. That's right. The comment is wrong (the extra '/') and perhaps your editor is insisting on the leading space (which causes the lines to appear to be removed and added back again). I can just fix this up here this time. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html