Re: [PATCH] uas: fix GFP_NOIO under spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 03/28/2014 05:42 PM, Greg KH wrote:
> On Fri, Mar 28, 2014 at 09:48:00AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 03/28/2014 09:45 AM, oliver@xxxxxxxxxx wrote:
>>> From: Oliver Neukum <oneukum@xxxxxxx>
>>>
>>> Quote Dan:
>>>
>>> The patch e36e64930cff: "uas: Use GFP_NOIO rather then GFP_ATOMIC
>>> where possible" from Nov 7, 2013, leads to the following static
>>> checker warning:
>>>
>>>         drivers/usb/storage/uas.c:806 uas_eh_task_mgmt()
>>>         error: scheduling with locks held: 'spin_lock:lock'
>>> The fix is obvious.
>>>
>>> Signed-off-by: Oliver Neukum <oliver@xxxxxxxxxx>
>>> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>
>> Dan, thanks for catching this, Oliver thanks for fixing this.
>>
>> Looks good to me, Greg can you please add this to usb-next?
>> It fixes a regression my uas set has introduced there.
> 
> I'll queue it up after 3.15-rc1 is out, thanks.

Great, thanks. Note Oliver has done a new version catching one
more instance (in essence reverting a patch I did where I
fsck-ed up). But I guess you've seen this already.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux