On Wed, Mar 26, 2014 at 08:43:09PM +0000, Sanders, Aaron wrote:
> Hi Johan,
>
> I found you name on the list of Maintainers for Linux for
> "drivers/usb/serial/". I have never submitted change before so I am
> looking for your help. I would like to submit a very simple patch to
> add some USB ID's for new HP Pole Displays to pl2303 driver. Attached
> is a patch file made using diff.
>
> What do I need to do? Thank you for your help!
The diff in itself looks good, but please have a look at
Documentation/SubmittingPatches on how to generate the patch and submit
it.
Specifically, you need to add a descriptive subject line and commit
message (have a look at the git log for usb-serial for inspiration,
e.g. commit 598f0b703506 ("USB: pl2303: add id for SMART device")), and
a Signed-off-by tag.
git format-patch (and git send-email) can also be quite handy.
And remember to CC the linux-usb list (added to CC).
Thanks,
Johan
> diff -uNr old/pl2303.c new/pl2303.c
> --- old/pl2303.c 2014-03-26 11:06:20.526852963 -0700
> +++ new/pl2303.c 2014-03-26 11:06:32.154852611 -0700
> @@ -82,6 +82,9 @@
> { USB_DEVICE(YCCABLE_VENDOR_ID, YCCABLE_PRODUCT_ID) },
> { USB_DEVICE(SUPERIAL_VENDOR_ID, SUPERIAL_PRODUCT_ID) },
> { USB_DEVICE(HP_VENDOR_ID, HP_LD220_PRODUCT_ID) },
> + { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
> + { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
> + { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
> { USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
> { USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
> { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
> diff -uNr old/pl2303.h new/pl2303.h
> --- old/pl2303.h 2014-03-26 11:06:11.030853251 -0700
> +++ new/pl2303.h 2014-03-26 11:06:37.462852450 -0700
> @@ -124,6 +124,9 @@
> /* Hewlett-Packard LD220-HP POS Pole Display */
> #define HP_VENDOR_ID 0x03f0
> #define HP_LD220_PRODUCT_ID 0x3524
> +#define HP_LD960_PRODUCT_ID 0x0B39
> +#define HP_LCM220_PRODUCT_ID 0x3139
> +#define HP_LCM960_PRODUCT_ID 0x3239
>
> /* Cressi Edy (diving computer) PC interface */
> #define CRESSI_VENDOR_ID 0x04b8
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
