On Wed, Mar 26, 2014 at 05:05:07PM +0800, liu.lei78@xxxxxxxxxx wrote:
>
> dear linuxfoundation:
> There have two question in the patch.
Plese don't send html email, the mailing list drops your emails :(
> Qestion 1: Move ZTE CDMA device pid fffe from zte_ev.c to option.c
> ZTE device pid of fffe can't connection when drops ppp connection every minute.
> There is normal when we move the pid to option。
>
> Qestion 2: Modify the parameter from 0x0003 to 0x0000.
> the problem may cause the device can not be closed, when we send 0x22 0x21
> 0x0003 in close serial ports.
> It must send 0x22 0x21 0x0000, We have checked Qualcomm document.
So, which one do you want to do? You are modifying both in your patch
below, should I take both of these?
>
>
>
> Signed-off-by:lei liu<liu.lei78@xxxxxxxxxx>
> diff -u -r drivers-old/usb/serial/option.c drivers/usb/serial/option.c
> --- drivers-old/usb/serial/option.c 2014-03-24 12:45:42.000000000 +0800
> +++ drivers/usb/serial/option.c 2014-03-26 15:13:02.232956251 +0800
> @@ -1462,6 +1462,7 @@
> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff92, 0xff, 0xff,
> 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff93, 0xff, 0xff,
> 0xff) },
> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff94, 0xff, 0xff,
> 0xff) },
> + { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xfffe, 0xff, 0xff,
> 0xff) },
>
> /* NOTE: most ZTE CDMA devices should be driven by zte_ev, not option
> */
> { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, ZTE_PRODUCT_MC2718,
> 0xff, 0xff, 0xff),
> Only in drivers/usb/serial: option.c~
> diff -u -r drivers-old/usb/serial/zte_ev.c drivers/usb/serial/zte_ev.c
> --- drivers-old/usb/serial/zte_ev.c 2014-03-24 12:45:42.000000000 +0800
> +++ drivers/usb/serial/zte_ev.c 2014-03-26 16:08:52.916827643 +0800
> @@ -258,12 +258,12 @@
>
> /* send 8 cmd */
> /*
> - * 16.0 CTL 21 22 03 00 00 00 00 00
> + * 16.0 CTL 21 22 00 00 00 00 00 00
> */
> len = 0;
> result = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> 0x22, 0x21,
> - 0x0003, 0x0000, NULL, len,
> + 0x0000, 0x0000, NULL, len,
> USB_CTRL_GET_TIMEOUT);
> dev_dbg(dev, "result = %d\n", result);
>
> @@ -276,7 +276,6 @@
> /* AC8710, AC8710T */
> { USB_DEVICE_AND_INTERFACE_INFO(0x19d2, 0xffff, 0xff, 0xff, 0xff) },
> /* AC8700 */
> - { USB_DEVICE_AND_INTERFACE_INFO(0x19d2, 0xfffe, 0xff, 0xff, 0xff) },
> /* MG880 */
> { USB_DEVICE(0x19d2, 0xfffd) },
> { USB_DEVICE(0x19d2, 0xfffc) },
> Only in drivers/usb/serial: zte_ev.c~
I think you should start using git to create your patches, that way the
"Only in..." messages will not show up.
Also, your patch is badly whitespace dammaged (no tabs, line-wrapped)
and can not be applied at all. Can you please resend it, in non-html
format, when you determine which option you think is the best?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
