On Thu, Mar 20, 2014 at 02:24:30PM -0700, Benjamin West wrote:
> Johan and other usb-serial/ftdi maintainers,
Thanks for the patch! A couple of minor issues below.
> Here is a small patch for you which adds the PID for Asante Snap
> Pump's FTDI data cable to the device list. The Asante Snap pump is an
> insulin pump, this device is a usb cable which connects to their
> cradle.
<snip>
> From 82bf3dcd649af33d8f41aa2098bd61bfa94cbc04 Mon Sep 17 00:00:00 2001
> From: Ben West <bewest@xxxxxxxxx>
> Date: Wed, 19 Mar 2014 20:34:33 -0700
> Subject: [PATCH] Add AsantePorter PID 0x7F38 to FTDI list
Please use
"[PATCH] USB: ftdi_sio: add AsantePorter PID 0x7F38"
or similar as subject (i.e. with a "USB: ftdi_sio: "-prefix).
> This patch allows the ftdi usb serial module to create a device when
> an Asante Porter usb data cable is plugged in.
>
> Signed-off-by: Ben West <bewest@xxxxxxxxx>
> ---
> drivers/usb/serial/ftdi_sio.c | 1 +
> drivers/usb/serial/ftdi_sio_ids.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 44ab129..7f26fa1 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -688,6 +688,7 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(EVOLUTION_VID, EVO_HYBRID_PID) },
> { USB_DEVICE(EVOLUTION_VID, EVO_RCM4_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_ARTEMIS_PID) },
> + { USB_DEVICE(FTDI_VID, FTDI_ASANTE_PORTER_PID) },
scripts/checkpatch.pl (a useful tool you should run your patches through
before submitting) complains:
WARNING: please, no spaces at the start of a line
#107: FILE: drivers/usb/serial/ftdi_sio.c:691:
+ { USB_DEVICE(FTDI_VID, FTDI_ASANTE_PORTER_PID) },$
> { USB_DEVICE(FTDI_VID, FTDI_ATIK_ATK16_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_ATIK_ATK16C_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_ATIK_ATK16HR_PID) },
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index e599fbf..0602fd6 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -194,6 +194,11 @@
> #define FTDI_ARTEMIS_PID 0xDF28 /* All Artemis Cameras */
>
> /*
> + * Definitions for Asante Porter, data cable for insulin pump.
> + */
> +#define FTDI_ASANTE_PORTER_PID 0x7F38 /* Asante Porter */
I'd use a tab to indent the comment after the define here.
> +
> +/*
> * Definitions for ATIK Instruments astronomical USB based cameras
> * Check it at http://www.atik-instruments.com/
> */
Care to fix that up and resubmit (then you should also add "v2" to your
subject line, as in, "[PATCH v2] USB: ...")?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
