On Wed, Mar 19, 2014 at 05:08:58PM +0530, Heena Sirwani wrote:
> Fix checkpatch.pl issues with line over 80 characters in Adapter.h
>
> Signed-off-by: Heena Sirwani <heenasirwani@xxxxxxxxx>
> ---
> drivers/staging/bcm/Adapter.h | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index 1b2d9f3..a387234 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -39,12 +39,14 @@ union u_ip_address {
> struct {
> /* Source Ip Address Range */
> ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
> - /* Source Ip Mask Address Range */
> + /* Source Ip Mask Address Range */
> ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
> };
> struct {
> - ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip Address Range */
> - ULONG ulIpv6Mask[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip Mask Address Range */
> + /* Source Ip Address Range */
> + ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4];
> + /* Source Ip Mask Address Range */
> + ULONG ulIpv6Mask[MAX_IP_RANGE_LENGTH * 4];
> };
> struct {
> UCHAR ucIpv4Address[MAX_IP_RANGE_LENGTH * IP_LENGTH_OF_ADDRESS];
> @@ -57,9 +59,11 @@ union u_ip_address {
> };
>
> struct bcm_hdr_suppression_contextinfo {
> - UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS]; /* Intermediate buffer to accumulate pkt Header for PHS */
> - UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN]; /* Intermediate buffer containing pkt Header after PHS */
> -};
> + /* Intermediate buffer to accumulate pkt Header for PHS */
> + UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS];
> + /* Intermediate buffer containing pkt Header after PHS */
> + UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN];
> + };
>
> struct bcm_classifier_rule {
> ULONG ulSFID;
> @@ -67,11 +71,12 @@ struct bcm_classifier_rule {
> B_UINT16 uiClassifierRuleIndex;
> bool bUsed;
> USHORT usVCID_Value;
> - B_UINT8 u8ClassifierRulePriority; /* This field detemines the Classifier Priority */
> + /* This field detemines the Classifier Priority */
> + B_UINT8 u8ClassifierRulePriority;
> union u_ip_address stSrcIpAddress;
> - UCHAR ucIPSourceAddressLength; /* Ip Source Address Length */
> -
> union u_ip_address stDestIpAddress;
> + /* Ip Source Address Length */
> + UCHAR ucIPSourceAddressLength;
You moved the fields areound in the structure, which mighe be just fine,
but if this is trying to match up with some hardware registers, could
break things badly.
So please don't do that, unless you "know" it's ok.
thanks,
greg kh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
