Re: [OPW kernel] [PATCH 12/16] staging: wlags49_h2: Do not use assignment in if condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 17 Mar 2014, Jelena Bjelja wrote:

> This patch fixes the following checkpatch.pl issue in wl_netdev.c:
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@xxxxxxxxx>
> ---
>  drivers/staging/wlags49_h2/wl_netdev.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c
> index e1661ff..d6cd00a 100644
> --- a/drivers/staging/wlags49_h2/wl_netdev.c
> +++ b/drivers/staging/wlags49_h2/wl_netdev.c
> @@ -1774,7 +1774,9 @@ int wl_rx_dma(struct net_device *dev)
>
>  	DBG_PARAM(DbgInfo, "dev", "%s (0x%p)", dev->name, dev);
>
> -	if (((lp = dev->priv) != NULL) &&
> +	lp = dev->priv;
> +

Probably there is no need for this blank line.

julia

> +	if ((lp != NULL) &&
>  		!(lp->flags & WVLAN2_UIL_BUSY)) {
>
>  #ifdef USE_RTS
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> For more options, visit https://groups.google.com/d/optout.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux