On Fri, Mar 14, 2014 at 08:52:49PM +0000, suresh.gupta@xxxxxxxxxxxxx wrote: > Hi, > > -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: Thursday, March 13, 2014 8:56 PM > To: Gupta Suresh-B42813 > Cc: balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] USB : Gadget: fsl: add information message > > On Thu, Mar 13, 2014 at 06:41:50PM +0530, Suresh Gupta wrote: > > Message helps to understand that the Freescale Gadget driver > > is up without any error. > > why this tab ? > [SuresH] I will remove it in next version > > > > > Signed-off-by: Suresh Gupta <suresh.gupta@xxxxxxxxxxxxx> > > --- > > drivers/usb/gadget/fsl_udc_core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > > b/drivers/usb/gadget/fsl_udc_core.c > > index 9a93727..455d0ab 100644 > > --- a/drivers/usb/gadget/fsl_udc_core.c > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > @@ -2503,6 +2503,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev) > > goto err_del_udc; > > > > create_proc_file(); > > + pr_info("%s (%s)\n", driver_desc, DRIVER_VERSION); > > if there are no messages, then it's up. Also, you can very easily check lsmod. > > sorry, but I'm not taking this. > [SuresH] The legacy driver shows this message when module_init was > used. To make same upbringing for customer, I added the same message > after probe get completed. This message will not make any difference > but will satisfies customer need. #!/bin/sh lsmod | grep fsl_usb2_udc if [ $? -eq 0 ]; then echo "Yeah, USB driver is loaded" else echo "Bad! Bad driver" fi Still not taking your patch -- balbi
Attachment:
signature.asc
Description: Digital signature
