Re: [PATCH] xhci: do not halt the secondary HCD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-03-14 at 18:16 -0300, Thadeu Lima de Souza Cascardo wrote:
> What seems to happen for the TI chip is that while the HID device is
> still connected (ie, we still have pending URBs on the queue), halting
> is not a great idea. And as described above, what is done right now
> is:

Can you tell us more about what "not a great idea" means ? :-)

IE, we have experienced actual errors, hangs and/or kexec failures
right ? You should describe them so people like Sarah can understand
better what's going on and why it's a problem.

> 1) disconnect USB 3.0 devices
> 2) halt
> 3) disconnect USB 2.0 devices
> 4) halt and cleanup
> 
> What I do is avoid halting before we disconnect the USB 2.0 devices.
> 
> We know that xhci_only_stop_hcd is only called for the secondary for
> which there is a primary with the same xhci. Much of that information
> is
> on the xhci driver itself, so we are not working around the upper
> layer
> more than the driver already is.
> 
> One option we have to be too much invasive here with other chipsets is
> skip the halt only for the TI host card, by using a new quirk.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux