> > On 12-03-2014 12:56, Peter Chen wrote: > > > From: Li Jun <B47624@xxxxxxxxxxxxx> > > > According to:"On-The-Go and Embedded Host Supplement to the USB > > Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a" > > - add a_wait_vrise to a_wait_vfall > > - update condition from a_wait_vrise to a_wait_bcon > > > Signed-off-by: Li Jun <b47624@xxxxxxxxxxxxx> > > --- > > drivers/usb/phy/phy-fsm-usb.c | 6 ++++-- > > 1 files changed, 4 insertions(+), 2 deletions(-) > > > diff --git a/drivers/usb/phy/phy-fsm-usb.c > > b/drivers/usb/phy/phy-fsm-usb.c index c47e5a6..0021839 100644 > > --- a/drivers/usb/phy/phy-fsm-usb.c > > +++ b/drivers/usb/phy/phy-fsm-usb.c > > @@ -303,9 +303,11 @@ int otg_statemachine(struct otg_fsm *fsm) > > otg_set_state(fsm, OTG_STATE_A_WAIT_VRISE); > > break; > > case OTG_STATE_A_WAIT_VRISE: > > - if (fsm->id || fsm->a_bus_drop || fsm->a_vbus_vld || > > - fsm->a_wait_vrise_tmout) { > > + if (fsm->a_vbus_vld) { > > otg_set_state(fsm, OTG_STATE_A_WAIT_BCON); > > + } else if (fsm->id || fsm->a_bus_drop || > > + fsm->a_wait_vrise_tmout) { > > + otg_set_state(fsm, OTG_STATE_A_WAIT_VFALL); > > } > > {} not needed in either arm of the *if* statement. See > Documentation/CodingStyle. checkpatch.pl used to complain about this. > Jun, change it please, and sent v2 patch with my two patches. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html