Re: [PATCH v3][ 5/9] ARM: dts: imx25.dtsi: Fix USB support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Denis,

On Wed, Mar 12, 2014 at 7:01 AM, Denis Carikli <denis@xxxxxxxxxx> wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> This patch was adapted from the thread named
> "USB Host support for mx25" on linux-usb@xxxxxxxxxxxxxxx
>

As you add me in the From field, you also need to add:

Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> above your
Signed-off-by line.

> Signed-off-by: Denis Carikli <denis@xxxxxxxxxx>
> +
> +       usbphy {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "simple-bus";

I made this comment earlier: why do we place usbphy0/1 under simple-bus?

This is not documented in the the bindings.

> +
> +               usbphy0: usbphy@0 {
> +                       reg = <0>;
> +                       compatible = "usb-nop-xceiv";
> +               };
> +
> +               usbphy1: usbphy@1 {
> +                       reg = <1>;
> +                       compatible = "usb-nop-xceiv";
> +               };
> +       };

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux