Re: [PATCH] xhci: extend quirk for Renesas cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-03-10 at 15:06 +0200, Mathias Nyman wrote: 
> On 03/09/2014 04:20 PM, Igor Gnatenko wrote:
> > After suspend another Renesas PCI-X USB 3.0 card doesn't work.
> > 03:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720202 USB 3.0 Host Controller [1912:0015] (rev 02) (prog-if 30 [XHCI])
> >
> > Reported-and-tested-by: Anatoly K. <rfr-bugs@xxxxxxxxx>
> > Reference: http://redmine.russianfedora.pro/issues/1315
> > Signed-off-by: Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx>
> > ---
> >   drivers/usb/host/xhci-pci.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index 04f986d..13d4add 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -143,9 +143,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> >   		xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> >   	}
> >   	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
> > -			pdev->device == 0x0015 &&
> > -			pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG &&
> > -			pdev->subsystem_device == 0xc0cd)
> > +			pdev->device == 0x0015)
> >   		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >   	if (pdev->vendor == PCI_VENDOR_ID_VIA)
> >   		xhci->quirks |= XHCI_RESET_ON_RESUME;
> >
> 
> This will set the resume quirk for all devices with a Renesas  uPD720202 
> host.
> 
> Do they all need this quirk, or should just this card manufacturer be 
> added to the quirk? (subsystem vendor/device)
I can't determine whay subsystem_(vendor|device) is needed for this
card. If you can help me determine this info - I can resend patch with
adding new quirk only for this device. 
> 
> -Mathias
-- 
-Igor Gnatenko

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux