On Fri, 2014-03-07 at 10:32 -0800, Sarah Sharp wrote: > On Tue, Feb 11, 2014 at 06:11:09PM +0100, Andreas Cadhalpun wrote: > > Hi, > > > > thanks for looking into the issue. > > > > On 11.02.2014 17:40, Sarah Sharp wrote: > > >On Sat, Feb 08, 2014 at 03:56:31AM +0000, Ben Hutchings wrote: > > >>For the benefit of other developers, that change is a revert of commit > > >>459d3c146117 ('usb: xhci: Link TRB must not occur within a USB payload > > >>burst') plus this effective revert of commit fc76051c453b ('USB: XHCI: > > >>mark no_sg_constraint'): > > > > > >I hope that's unrelated. I was effectively going to do the same thing > > >upstream (except allow the no_sg_constraint to be set on 0.96 and > > >earlier hosts). > > > > I don't know what else changed from 3.12.8-1 to 3.12.9-1, but this > > was the only point in the changelog mentioning xhci. > > Alan and I concluded that the cause of this issue is clearing the > no_sg_constraint flag for 1.0 xHCI hosts. The patches to revert the > commits that caused the issues are on their way to the USB subsystem > maintainer (Greg): > > http://marc.info/?l=linux-kernel&m=139420433008427&w=2 > http://marc.info/?l=linux-kernel&m=139420429908418&w=2 > http://marc.info/?l=linux-kernel&m=139420432208425&w=2 > > The second commit is needed, since once we allow arbitrarily-aligned > scatter-gather, the ASIX driver will use it, which causes the USB to > ethernet adapter to drop packets occasionally. > > So we're basically back where we started before 3.12. [...] I thought we were already there. Thanks for letting us know about the additional reverts - I'll apply them in the next Debian update for 3.13. Ben. -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure.
Attachment:
signature.asc
Description: This is a digitally signed message part