On Wed, Mar 05, 2014 at 01:11:15PM +0100, Christian Riesch wrote: > Signed-off-by: Christian Riesch <christian.riesch@xxxxxxxxxx> > Cc: Felipe Balbi <balbi@xxxxxx> > --- > Hi, > > I have successfully tested this driver with kernel 3.14-rc5 on a custom > Texas Instruments AM1808 board in gadget mode, RNDIS network gadget. > Therefore I think the dependency on BROKEN can be removed. > > Commit 787f5627bec80094db487bfcb401e9744f181aed that added this dependancy > states that the dependency on <mach/> headers should also be removed. > Currently, the CFGCHIP2 define in the code is the only reason why a > <mach/> header is included in the file, so I am replacing it with the > hardcoded address. > > Regards, Christian > > > drivers/usb/musb/Kconfig | 1 - > drivers/usb/musb/da8xx.c | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > index 688dc8b..af370a4 100644 > --- a/drivers/usb/musb/Kconfig > +++ b/drivers/usb/musb/Kconfig > @@ -67,7 +67,6 @@ config USB_MUSB_DAVINCI > config USB_MUSB_DA8XX > tristate "DA8xx/OMAP-L1x" > depends on ARCH_DAVINCI_DA8XX > - depends on BROKEN > > config USB_MUSB_TUSB6010 > tristate "TUSB6010" > diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c > index e3486de..6f4d8c7 100644 > --- a/drivers/usb/musb/da8xx.c > +++ b/drivers/usb/musb/da8xx.c > @@ -34,7 +34,6 @@ > #include <linux/dma-mapping.h> > #include <linux/usb/usb_phy_gen_xceiv.h> > > -#include <mach/da8xx.h> > #include <linux/platform_data/usb-davinci.h> > > #include "musb_core.h" > @@ -80,7 +79,7 @@ > > #define DA8XX_MENTOR_CORE_OFFSET 0x400 > > -#define CFGCHIP2 IO_ADDRESS(DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG) > +#define CFGCHIP2 IOMEM(UL(0xfec14184)) the right way, would be to convert phy_on()/phy_off() into a real drivers/phy/phy-da8xx.c driver, then remove references to the nop transceiver from drvers/usb/musb/da8xx.c cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
