On Mon, Mar 03, 2014 at 04:52:27PM -0600, Felipe Balbi wrote: > On Mon, Mar 03, 2014 at 02:46:32PM -0800, Greg KH wrote: > > On Mon, Mar 03, 2014 at 11:04:02AM -0600, Felipe Balbi wrote: > > > during the conversion to a new method of finding > > > proper endpoints, we need to give our users a > > > grace period until full conversion is finished. > > > > Who are these "users"? kernel developers? Or end-users? > > kernel developers. > > > > This patch adds a new internal and temporary > > > __uses_feature_flags flag which will tell gadget > > > framework that this UDC has been converted to > > > the new feature flag-based endpoint scheme. > > > > > > Once all gadget drivers are converted, this > > > flag will be removed. > > > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > --- > > > drivers/usb/dwc3/gadget.c | 1 + > > > drivers/usb/gadget/epautoconf.c | 48 +++++++++++++++++++++-------------------- > > > drivers/usb/gadget/s3c-hsotg.c | 1 + > > > include/linux/usb/gadget.h | 2 ++ > > > 4 files changed, 29 insertions(+), 23 deletions(-) > > > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > index eaf8537..54b40ce 100644 > > > --- a/drivers/usb/dwc3/gadget.c > > > +++ b/drivers/usb/dwc3/gadget.c > > > @@ -2733,6 +2733,7 @@ int dwc3_gadget_init(struct dwc3 *dwc) > > > dwc->gadget.speed = USB_SPEED_UNKNOWN; > > > dwc->gadget.sg_supported = true; > > > dwc->gadget.name = "dwc3-gadget"; > > > + dwc->gadget.__uses_feature_flags = true; > > > > I don't really understand what this is doing for anyone. Can't we just > > fix up all in-kernel users of the flags properly? > > I can try to do that, yes, but for v3.15 might be quite a bit of work. > Anyway, I guess we still have a few days left. I have dropped those patches from my "next" branch, it'll give me more time to make this right for v3.16. -- balbi
Attachment:
signature.asc
Description: Digital signature
