Re: [RESEND PATCHv2 1/3] usb: dwc2: Add defines to support the s3c-hsotg driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 03, 2014 at 09:06:13PM -0600, dinguyen@xxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> 
> In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver,
> the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can
> use them.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: Matt Porter <mporter@xxxxxxxxxx>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Cc: Matthijs Kooijman <matthijs@xxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> ---
> v2:
> - No need to redo the GRXSTS_PKTSTS defines
> - Add a FIFOSIZE_DEPTH_GET macro
> ---
>  drivers/usb/dwc2/hw.h |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hw.h b/drivers/usb/dwc2/hw.h
> index 9c92a3c..18e19cd 100644
> --- a/drivers/usb/dwc2/hw.h
> +++ b/drivers/usb/dwc2/hw.h
> @@ -109,6 +109,7 @@
>  #define GUSBCFG_FSINTF			(1 << 5)
>  #define GUSBCFG_ULPI_UTMI_SEL		(1 << 4)
>  #define GUSBCFG_PHYIF16			(1 << 3)
> +#define GUSBCFG_PHYIF8			(0 << 3)
>  #define GUSBCFG_TOUTCAL_MASK		(0x7 << 0)
>  #define GUSBCFG_TOUTCAL_SHIFT		0
>  #define GUSBCFG_TOUTCAL_LIMIT		0x7
> @@ -403,6 +404,7 @@
>  #define FIFOSIZE_DEPTH_SHIFT		16
>  #define FIFOSIZE_STARTADDR_MASK		(0xffff << 0)
>  #define FIFOSIZE_STARTADDR_SHIFT	0
> +#define FIFOSIZE_DEPTH_GET(_x)		(((_x) >> 16) & 0xffff)
>  
>  /* Device mode registers */
>  
> @@ -520,10 +522,11 @@
>  #define DXEPCTL_SNP			(1 << 20)
>  #define DXEPCTL_EPTYPE_MASK		(0x3 << 18)
>  #define DXEPCTL_EPTYPE_SHIFT		18

you can remove this now, if there are still any uses, remove them.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux