Re: [PATCHv2 3/3] usb: s3c-hsotg: Move s3c-hsotg data structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 03, 2014 at 05:09:29PM -0600, dinguyen@xxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> 
> This patch moves the data structures that are in the s3c-hsotg source into
> core.h. This is a necessary step towards unifying the s3c-hsotg and dwc2 into
> a single DRD.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Cc: Matt Porter <mporter@xxxxxxxxxx>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Cc: Matthijs Kooijman <matthijs@xxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> Cc: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> ---
> v2: none
> ---
>  drivers/usb/dwc2/core.h      |  182 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/usb/dwc2/s3c-hsotg.c |  180 +----------------------------------------
>  2 files changed, 183 insertions(+), 179 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index 648519c..1efd10c 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -37,6 +37,10 @@
>  #ifndef __DWC2_CORE_H__
>  #define __DWC2_CORE_H__
>  
> +#include <linux/phy/phy.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/usb/gadget.h>
> +#include <linux/usb/otg.h>
>  #include <linux/usb/phy.h>
>  #include "hw.h"
>  
> @@ -54,6 +58,184 @@ static inline void do_write(u32 value, void *addr)
>  /* Maximum number of Endpoints/HostChannels */
>  #define MAX_EPS_CHANNELS	16
>  
> +/* s3c-hsotg declarations */
> +static const char * const s3c_hsotg_supply_names[] = {
> +	"vusb_d",               /* digital USB supply, 1.2V */
> +	"vusb_a",               /* analog USB supply, 1.1V */
> +};

this might be a good time to fix this crap. It really looks like these
two regulators should be part of a PHY driver instead, no ? Can someone
confirm ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux