Re: MAX3421E Linux driver?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 2, 2014 at 10:04 AM, Peter Stuge <peter@xxxxxxxx> wrote:
>
> David Mosberger wrote:
> > +++ b/drivers/usb/host/Kconfig
> > @@ -4,6 +4,16 @@
> >  comment "USB Host Controller Drivers"
> >       depends on USB
> >
> > +config USB_MAX3421_HCD
> > +       tristate "MAX3421 HCD (USB-over-SPI) support"
> > +       depends on USB
> > +       help
> > +         The Maxim MAX3421E Host Controller Interface supports
> > +      standard USB 1.1 high-speed hardware.
>
> I'd suggest "supports USB 2.0-compliant full-speed devices" instead.

Yeah, that comment was old and wrong.  I fixed that per your suggestion, thanks.

> And before you assume that high-speed devices (flash drives, wlan, etc)
> don't work correctly because of something your driver does I would
> strongly recommend to perform the same tests using another full-speed
> HC, e.g. by using uhci_hcd as the only hcd, disabling ehci_hcd, on
> EHCI hardware.
>
> I've seen high-speed-capable devices work quite poorly at full-speed;
> who cares about correctness when there is performance?

At first, we had problems recognizing high-speed devices, but that
must have been a silly bug since it got fixed without me even trying.
Certainly there can be cases where high-speed devices wouldn't work
properly at full speed, but I don't think I'm ready to blame the
devices over my driver just yet.  I may change my mind on this, of
course. ;-)

  --david

-- 
eGauge Systems LLC, http://egauge.net/, 1.877-EGAUGE1, fax 720.545.9768
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux