Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


On Wed, Feb 26, 2014 at 11:00:33PM +0000, Paul Zimmerman wrote:
> Hi Felipe,
> 
> Can you drop the part that checks the DCNRD bit, please? I made a
> mistake when I originally submitted this. It is not necessary to check
> the DCNRD bit every time before reading the link state, it should only
> be checked the first time after coming out of hibernation. Doing it
> every time is unnecessary overhead, and can even cause problems with a
> hibernation-enabled controller.
> 
> So for now maybe just drop the entire patch, and instead call
> DWC3_DSTS_USBLNKST() directly?

I removed the DCNRD check but kept the function around. updated patch
pushed to dwc3-hibernation

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux