Hi, On 02/27/2014 01:47 PM, Jingoo Han wrote: > Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler. > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > --- > drivers/usb/phy/phy-am335x.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c > index 12fc346..ebf8373 100644 > --- a/drivers/usb/phy/phy-am335x.c > +++ b/drivers/usb/phy/phy-am335x.c > @@ -123,9 +123,7 @@ static int am335x_phy_resume(struct device *dev) > return 0; > } > > -static const struct dev_pm_ops am335x_pm_ops = { > - SET_SYSTEM_SLEEP_PM_OPS(am335x_phy_suspend, am335x_phy_resume) > -}; > +static SIMPLE_DEV_PM_OPS(am335x_pm_ops, am335x_phy_suspend, am335x_phy_resume); You need to move this outside the #ifdef CONFIG_PM_SLEEP condition and get rid of the DEV_PM_OPS macro below as well. > > #define DEV_PM_OPS (&am335x_pm_ops) > #else > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html