On Thu, Feb 27, 2014 at 5:16 PM, Weinn <clanlab.proj@xxxxxxxxx> wrote: > I've found that the NAPI version of my implementation was slower then > the previous work queue implementation. > I think I can post it later and let's see where the parameters codes/ > could be adjustment. > Currently the weight/budget of rx_napi is 16 (GETHER_NAPI_WEIGHT == 16) > netif_napi_add(net, &dev->rx_napi, gether_poll, GETHER_NAPI_WEIGHT); > > Should I send a new patch which with new description about NAPI version? > Or should I just send the patch v3 and use the same patch subject? > > Here is the benchmark (USB High speed) on RX channel. (PC->Device) Hi all, After I've replaced the WEIGHT/budget from 16 -> 32, I've got better performance from previous NAPI version, but still cannot beat the work queue version. Here is the result.. With NAPI: WEIGHT/budget == 32 [ 3] 10.0-11.0 sec 9.88 MBytes 82.8 Mbits/sec [ 3] 11.0-12.0 sec 9.38 MBytes 78.6 Mbits/sec [ 3] 12.0-13.0 sec 10.1 MBytes 84.9 Mbits/sec [ 3] 13.0-14.0 sec 10.2 MBytes 86.0 Mbits/sec [ 3] 14.0-15.0 sec 10.0 MBytes 83.9 Mbits/sec [ 3] 15.0-16.0 sec 10.5 MBytes 88.1 Mbits/sec [ 3] 16.0-17.0 sec 9.38 MBytes 78.6 Mbits/sec [ 3] 17.0-18.0 sec 10.4 MBytes 87.0 Mbits/sec [ 3] 18.0-19.0 sec 10.4 MBytes 87.0 Mbits/sec > > With work queue is implemented. > [ 3] 2.0- 3.0 sec 9.75 MBytes 81.8 Mbits/sec > [ 3] 3.0- 4.0 sec 10.4 MBytes 87.0 Mbits/sec > [ 3] 4.0- 5.0 sec 10.2 MBytes 86.0 Mbits/sec > [ 3] 5.0- 6.0 sec 10.4 MBytes 87.0 Mbits/sec > [ 3] 6.0- 7.0 sec 10.4 MBytes 87.0 Mbits/sec > [ 3] 7.0- 8.0 sec 9.88 MBytes 82.8 Mbits/sec > [ 3] 8.0- 9.0 sec 10.5 MBytes 88.1 Mbits/sec > [ 3] 9.0-10.0 sec 10.5 MBytes 88.1 Mbits/sec > > With NAPI is WEIGHT/budget == 16 > [ 3] 23.0-24.0 sec 9.25 MBytes 77.6 Mbits/sec > [ 3] 24.0-25.0 sec 9.50 MBytes 79.7 Mbits/sec > [ 3] 25.0-26.0 sec 9.75 MBytes 81.8 Mbits/sec > [ 3] 26.0-27.0 sec 9.25 MBytes 77.6 Mbits/sec > [ 3] 27.0-28.0 sec 9.12 MBytes 76.5 Mbits/sec > [ 3] 28.0-29.0 sec 10.4 MBytes 87.0 Mbits/sec > [ 3] 29.0-30.0 sec 10.1 MBytes 84.9 Mbits/sec > [ 3] 30.0-31.0 sec 9.62 MBytes 80.7 Mbits/sec > [ 3] 31.0-32.0 sec 10.0 MBytes 83.9 Mbits/sec -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html