On Fri, Feb 07, 2014 at 02:42:45PM -0800, Greg KH wrote: > On Fri, Jan 31, 2014 at 02:29:52AM -0200, Fabio Estevam wrote: > > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > > > Using module_platform_driver() can make the code simpler. > > > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > --- > > Build-tested only > > No you didn't: > drivers/usb/host/xhci-plat.o: In function `usb_xhci_driver_init': > xhci-plat.c:(.init.text+0x0): multiple definition of `init_module' > drivers/usb/host/xhci.o:xhci.c:(.init.text+0x0): first defined here > drivers/usb/host/xhci-plat.o: In function `usb_xhci_driver_exit': > xhci-plat.c:(.exit.text+0x0): multiple definition of `cleanup_module' > drivers/usb/host/xhci.o:xhci.c:(.exit.text+0x0): first defined here > > Please be more careful... Fabio, are you going to send a new version that fixes these build errors? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html