Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 24 Feb 2014, Dan Williams wrote:

> > Also, the gyrations you have to go through here and elsewhere to print
> > useful names indicate that we should set up better names for the port
> > devices.  How about:
> >
> >         dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev),
> >                         port1);
> 
> I like it, however isn't this an ABI change that could mess up existing scripts?

What existing scripts?  Right now the only useful information is the 
connect_type attribute.  Unless you think people are already using the 
power-off facility?

> What's worse, in-kernel gymnastics to print out useful names, or
> adding sysfs links from the old short name to the new name?

Normally I'd agree, but this is a marginal case.  What do other people 
think?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux