> -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx] > Sent: Wednesday, February 19, 2014 12:10 AM > To: Krzysztof Opasiak; mporter@xxxxxxxxxx; linux- > usb@xxxxxxxxxxxxxxx > Cc: Andrzej Pietrasiewicz; Karol Lewandowski; Stanislaw Wadas; > Aleksander Zdyb; ty317.kim@xxxxxxxxxxx; Marek Szyprowski; Robert > Baldyga > Subject: Re: [PATCH 05/25] libusbg: Update strings only when > writting US English strings. > > Hello. > > On 02/19/2014 02:07 AM, Sergei Shtylyov wrote: > > >> Strings in current verison of library are hardcoded to > >> US English. Functions which set strings are generic and > >> allow to set other languages, but internal library structures > >> should be update only when setting US English strings. > > >> Signed-off-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx> > [...] > > > I guess you haven't run your patch via scripts/checkpatch.pl, > otherwise > > you would have seen it protesting against single statement *if* > arms in {}. > > Well, some common sense applies as well since {} are completely > unnecessary. > > Ah, I have initially overlooked that it's libusbg patch -- > libusbg may > have its own style peculiarities. Assuming Matt prefer kernel style comments, rest of the coding style should be also consistent with kernel. I have been using some framework which surrounds single if statements with {}, so I was used to that style. I will fix this for v2. Thank you for your remarks. -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics k.opasiak@xxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
