On 18 February 2014 20:58, Felipe Balbi <balbi@xxxxxx> wrote: > On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote: >> Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. >> Fixes the following compilation error introduced by commit e117e742d310 >> ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"): >> >> drivers/usb/gadget/s3c2410_udc.c: In function 's3c2410_udc_reinit': >> drivers/usb/gadget/s3c2410_udc.c:1632:3: error: >> cannot take address of bit-field 'maxpacket' >> usb_ep_set_maxpacket_limit(&ep->ep, &ep->ep.maxpacket); >> >> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> Reviewed-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > > is this still needed for -rc4 ? I just verified on latest linux-next and we still get build errors without this patch. Hence, yes this patch is required for the current rc. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html