Re: [PATCH] u_ether: move receiving to RX workqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Feb 17, 2014 at 02:26:54PM +0800, Clanlab (Taiwan) Linux Project wrote:
> @@ -1168,5 +1191,23 @@ void gether_disconnect(struct gether *link)
>  }
>  EXPORT_SYMBOL(gether_disconnect);
>  
> +static int __init gether_init(void)
> +{
> +	gether_wq  = create_singlethread_workqueue("gether");
> +	if (gether_wq == NULL) {
> +		pr_err("Cannot initialize work queue\n");
> +		return -ENOMEM;
> +	}
> +	return 0;
> +}
> +module_init(gether_init);
> +
> +static void __exit gether_exit(void)
> +{
> +	destroy_workqueue(gether_wq);
> +

trailing whitespace.

> +}
> +module_exit(gether_exit);

this is actually supposed to be a library which gets linked against the
actual function module. You need to find a better way to ensure
destroy_workqueue is called.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux