On Mon, Feb 03, 2014 at 11:57:32AM +0100, Christian Riesch wrote: > Hi, > > commit 787f5627bec80094db487bfcb401e9744f181aed > usb: musb: make davinci and da8xx glues depend on BROKEN > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > adds a dependency of the drivers/usb/musb/da8xx.c driver to BROKEN. > > I have successfully tested this driver with kernel 3.13 on a custom > Texas Instruments AM1808 board in gadget mode, RNDIS network gadget. > > Therefore I would like to see this BROKEN dependency removed. What > would be required for removing this dependency? Is removing the > include of the <mach/da8xx.h> header sufficient? In the mailing list yeah. Remove <mach/da8xx.h> and make sure it builds cleanly on other arches. > discussion on the patch, Sergei Shtylyov mentioned that this would > mean duplicating the definitions. Would this be ok, just copying them > to drivers/usb/musb/da8xx.c? whatever is used by mach and driver should be sitting in a public header which both include. Say something like <linux/usb/musb-da8xx.h> or something similar. -- balbi
Attachment:
signature.asc
Description: Digital signature
