On Fri, Feb 14, 2014 at 03:26:32PM +1100, renevant@xxxxxxxxxxxxxxxx wrote: > wrong again, nic locked up with sg enabled, took a long time though. > > > The patch with the check removed doesn't appear to break anything that wasn't > already broken though. How about with scatter gather disabled? If the removal of the hard_header_len check doesn't have a negative impact on the device we don't need to introduce it to ax88179_rx_fixup(). Best regards, Emil Goode > On Friday 14 February 2014 13:25:38 renevant@xxxxxxxxxxxxxxxx wrote: > > This patch appears to be a winner. > > > > > > My system appears to be completely stable with the check removed and scatter > > gather enabled with a ax88179. > > > > Currently running... > > > > Linus tree merged with for-usb-linus branch of the XHCI tree > > > > commit 247bf557273dd775505fb9240d2d152f4f20d304 reverted > > > > https://git.kernel.org/cgit/linux/kernel/git/sarah/xhci.git/commit/?h=for-us > > b-linus&id=247bf557273dd775505fb9240d2d152f4f20d304 > > > > > > Your patch applied with the check removed from the ax88179_178a driver. > > > > This patch also applied: > > > > [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving > > NET_IP_ALIGN bytes > > > > http://marc.info/?l=linux-usb&m=138692843510886&w=2 > > > > > > > > 100% stable with scatter gather enabled whereas before the nic would lock up > > doing certain traffic. > > > > > > Regards, > > > > Will Trives > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html