Re: [RFC] usb: remove "clear_halt for a busy endpoint" warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 14 Feb 2014, Bjørn Mork wrote:

> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> > On Thu, 13 Feb 2014, Bjørn Mork wrote:
> >> Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> >> 
> >> >>  Schould we request to fix that in
> >> >> user space, or can we remove this warning like on below patch (call
> >> >> CLEAR_HALT ioctl, does not seems to do any harm except printing a
> >> >> warning) ?
> >> >
> >> > Doing an endpoint reset while URBs are queued is a bug, because the
> >> > results are not defined.  It should be fixed in the userspace program.
> >> 
> >> Maybe the usbfs driver should catch bugs like this and log a message
> >> pointing to the buggy userspace "driver" instead of blindly forwarding
> >> the clear halt?  That would make it more obvious that this is not a
> >> kernel bug.
> >
> > You mean something like this?
> 
> Yes, that looks nice.  And maybe even reject the command to avoid the
> warning from the hcd?

No, I don't want to reject the command.  That could break existing 
programs.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux