On Mon, Feb 10, 2014 at 06:49:44PM +0100, Christian Vogel wrote:
> The "Webmail Notifier" is a USB controlled LED that appears as a HID
> device. When trying to change the LED via hidraw it returns malformed
> reports. As "usbled" supports it, we blacklist it in usbhid.
>
> Signed-off-by: Christian Vogel <vogelchr@xxxxxxxx>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/usbhid/hid-quirks.c | 2 ++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index f9304cb..d936a9d 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -942,4 +942,7 @@
> #define USB_VENDOR_ID_SIS 0x0457
> #define USB_DEVICE_ID_SIS_TS 0x1013
>
> +#define USB_VENDOR_ID_RISO_KAGAKU 0x1294 /* Riso Kagaku Corp. */
> +#define USB_DEVICE_ID_RI_KA_WEBMAIL 0x1320 /* Webmail Notifier */
> +
> #endif
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 0db9a67..0da367c 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -116,6 +116,8 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_LTS2, HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_SIS, USB_DEVICE_ID_SIS_TS, HID_QUIRK_NO_INIT_REPORTS },
>
> + { USB_VENDOR_ID_RISO_KAGAKU, USB_DEVICE_ID_RI_KA_WEBMAIL, HID_QUIRK_IGNORE }, /* handled by usbled */
> +
Hm, no, this should be added to the hid_ignore_list[] in
drivers/hid/hid-core.c instead. Otherwise this is the only device with
that flag in this structure, which isn't good.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
