RE: [PATCH v2] tools: usb: aio example applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Robert Baldyga 
> This patch adds two example applications showing usage of Asynchronous I/O API
> of FunctionFS. First one (aio_simple) is simple example of bidirectional data
> transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which
> may to be used in high performance applications.
...
> +static const struct {
> +	struct usb_functionfs_descs_head header;
> +	struct {
> +		struct usb_interface_descriptor intf;
> +		struct usb_endpoint_descriptor_no_audio bulk_sink;
> +		struct usb_endpoint_descriptor_no_audio bulk_source;
> +	} __attribute__ ((__packed__)) fs_descs, hs_descs;

Does this actually need to be marked 'packed' ?
And the other structures below.
You shouldn't really mark things as packed unless they actually
have misaligned fields (in order to match an externally defined
memory layout), or because the memory for them might actually
be misaligned.

...
> +void init_bufs()

This should be:
void init_bufs(void)

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux