On Mon, Jan 27, 2014 at 3:27 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 27 Jan 2014, Josh Boyer wrote:
>
>> On Mon, Jan 27, 2014 at 3:44 PM, Sergei Shtylyov
>> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
>> > Hello.
>> >
>> >
>> > On 01/27/2014 10:23 PM, Josh Boyer wrote:
>> >
>> >> the PHY layer is supposed to be optional,
>> >> considering some PHY have no control bus
>> >> for SW to poke around.
>> >
>> >
>> >> After commit 1ae5799 (usb: hcd: Initialize
>> >> USB phy if needed) any HCD which didn't provide
>> >> a PHY driver would emit annoying error messages.
>> >
>> >
>> >> In this patch we're decreasing those messages
>> >> to dev_dbg for debugging only and so we know where
>> >> they're coming from.
>> >
>> >
>> >> Reported-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>> >> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>> >> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>> >> ---
>> >
>> >
>> >> v2: Switch to using dev_dbg
>> >
>> >
>> >> drivers/usb/phy/phy.c | 8 +++-----
>> >> 1 file changed, 3 insertions(+), 5 deletions(-)
>> >
>> >
>> >> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
>> >> index e6f61e4..db18011 100644
>> >> --- a/drivers/usb/phy/phy.c
>> >> +++ b/drivers/usb/phy/phy.c
>> >> @@ -130,7 +130,7 @@ struct usb_phy *usb_get_phy(enum usb_phy_type type)
>> >>
>> >> phy = __usb_find_phy(&phy_list, type);
>> >> if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
>> >> - pr_err("unable to find transceiver of type %s\n",
>> >> + dev_dbg(phy->dev, "unable to find transceiver of type
>> >> %s\n",
>> >
>> >
>> > 'phy' is possibly invalid (error ptr) at this point, you cannot
>> > dereference it.
>>
>> Oh, yes. Duh, I should have spotted that.
>>
>> Felipe, can we just go with your original patch? It avoids having to
>> worry about the dev parameter to dev_dbg.
>
> Josh, don't worry about it. Simply rewrite the patch using pr_debug
> here, but leave the second instance as dev_dbg.
Yeah, not a big deal. I can send a fixed up patch, but it likely
won't be until tomorrow. In the meantime, I tested Felipe's patch and
replied accordingly.
josh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
