On Thu, Jan 23, 2014 at 5:01 PM, Johan Hovold <johan@xxxxxxxxxx> wrote: > On Thu, Jan 23, 2014 at 03:59:37PM +0100, RALOVICH, Kristof wrote: >> From: RALOVICH, Kristof <kristof.ralovich@xxxxxxxxx> > > Don't you want to use "Kristóf Ralovich" here as well? That will be the > name of the author in the git logs. > >> Add support for ANT USB-m Stick from Dynastream Innovations, by listing USB pid >> >> [34366.944805] usb 6-1: New USB device found, idVendor=0fcf, idProduct=1009 >> [34366.944817] usb 6-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 >> [34366.944824] usb 6-1: Product: ANT USB-m Stick >> [34366.944831] usb 6-1: Manufacturer: Dynastream Innovations >> >> Device reported (https://code.google.com/p/antpm/issues/detail?id=5) to work through: >> $ modprobe usbserial vendor=0x0fcf product=0x1009 > > Thanks for the patch. There are some style issues reported by > checkpatch.pl, though: > > WARNING: line over 80 characters > #34: FILE: drivers/usb/serial/usb-serial-simple.c:76: > + { USB_DEVICE(0x0fcf, 0x1009) } /* ANT USB-m Stick from Dynastream Innovations */ > > WARNING: please, no spaces at the start of a line > #34: FILE: drivers/usb/serial/usb-serial-simple.c:76: > + { USB_DEVICE(0x0fcf, 0x1009) } /* ANT USB-m Stick from Dynastream Innovations */$ > > total: 0 errors, 2 warnings, 9 lines checked > > That is, you should use a tab for indentation, and perhaps you can > shorten the description somewhat? To say, "Dynastream ANT USB-m Stick"? > > Please use tabs when indenting the line continuation character as well > (or just keep it where it is). > > Care to fix that up and resend? > > Thanks, > Johan > > >> Signed-off-by: Kristóf Ralovich <kristof.ralovich@xxxxxxxxx> >> --- >> drivers/usb/serial/usb-serial-simple.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c >> index 52eb91f..6d5cb8f 100644 >> --- a/drivers/usb/serial/usb-serial-simple.c >> +++ b/drivers/usb/serial/usb-serial-simple.c >> @@ -72,7 +72,8 @@ DEVICE(hp4x, HP4X_IDS); >> >> /* Suunto ANT+ USB Driver */ >> #define SUUNTO_IDS() \ >> - { USB_DEVICE(0x0fcf, 0x1008) } >> + { USB_DEVICE(0x0fcf, 0x1008) }, \ >> + { USB_DEVICE(0x0fcf, 0x1009) } /* ANT USB-m Stick from Dynastream Innovations */ >> DEVICE(suunto, SUUNTO_IDS); >> >> /* Siemens USB/MPI adapter */ Dear Johen, thank you for the review. Hopefully my second patch (sent yesterday) addresses the concerns. Thanks, Kristof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
