Re: [PATCH] usb: host: xhci: fix HALTED endpoint handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/23/2014 02:13 AM, Sarah Sharp wrote:
If it really matters that a driver be able to get an immediate -EPIPE
response back from a device when the endpoint is halted, I can rip the
code out of xhci_endpoint_reset() and make the driver manually clean up
the ring at the time of the stall, like it does for control endpoints
and babble/transfer/split TX errors.  If it doesn't matter, test #13
should be changed to only submit one URB and get back an -EPIPE
response.

In theory, errors caused by the device sending a STALL should be
handled just like other sorts of errors.  After the URB which got the
STALL has been given back, the HCD should automatically restart the
endpoint ring.  It should not wait for usb_clear_halt.

Mathias, can you look into fixing this?  I know you're working on the
code to use a configure endpoint command when we can't issue a reset
endpoint command, and this change is definitely related.  It may even
simplify the code to make this change first.


I'll take a look at it, but it might take a few days before I get it done.

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux