Re: [PATCH] USB: chipidea: fix up coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 09, 2014 at 07:40:46PM +0530, Rahul Bedarkar wrote:
> On Thu, Jan 9, 2014 at 4:38 AM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Jan 08, 2014 at 10:04:04PM +0530, Rahul Bedarkar wrote:
> >>
> >> Signed-off-by: Rahul Bedarkar <rahulbedarkar89@xxxxxxxxx>
> >> ---
> >>  drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
> >>  drivers/usb/chipidea/core.c        | 9 +++++----
> >>  drivers/usb/chipidea/host.c        | 3 ++-
> >>  drivers/usb/chipidea/udc.c         | 9 ++++++---
> >>  4 files changed, 15 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> >> index bb5d976..4573cb9 100644
> >> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> >> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> >> @@ -53,7 +53,8 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
> >>       ret = of_parse_phandle_with_args(np, "fsl,usbmisc", "#index-cells",
> >>                                       0, &args);
> >>       if (ret) {
> >> -             dev_err(dev, "Failed to parse property fsl,usbmisc, errno %d\n",
> >> +             dev_err(dev,
> >> +                     "Failed to parse property fsl,usbmisc, errno %d\n",
> >
> > Why did you make this change?  It's ok to use the 80th column.
> 
> cleanfile script reported line exceeds 79 characters. I was not sure
> if it is ok to use the 80th column.

What is "cleanfile"?  checkpatch.pl sure doesn't complain about it, so
please don't "fix" something that's not needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux