Hello Andrzej Pietrasiewicz,
This is a semi-automatic email about new static checker warnings.
The patch 5920cda62768: "usb: gadget: FunctionFS: convert to new
function interface with backward compatibility" from Dec 3, 2013,
leads to the following Smatch complaint:
drivers/usb/gadget/f_fs.c:2596 ffs_release_dev()
error: we previously assumed 'ffs_dev' could be null (see line 2593)
drivers/usb/gadget/f_fs.c
2592 ffs_dev = ffs_data->private_data;
2593 if (ffs_dev)
^^^^^^^
Existing check.
2594 ffs_dev->mounted = false;
2595
^^^^^^^^^^
Patch introduces an unwanted tab char here. Use checkpatch.pl.
2596 if (ffs_dev->ffs_release_dev_callback)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Patch adds unchecked dereference.
2597 ffs_dev->ffs_release_dev_callback(ffs_dev);
2598
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
