The return value should be the boolean value, not the error code. Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx> Spotted-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e3d878c..13fabbb 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2708,7 +2708,7 @@ static bool rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id) ops->unload = rtl8153_unload; break; default: - ret = -EFAULT; + ret = false; break; } break; -- 1.8.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html